Skip to content

Comment suppport mssql fabric fix#5862

Merged
StuffbyYuki merged 8 commits into
SQLMesh:mainfrom
integrityauthority:comment_suppport_mssql
Jun 29, 2026
Merged

Comment suppport mssql fabric fix#5862
StuffbyYuki merged 8 commits into
SQLMesh:mainfrom
integrityauthority:comment_suppport_mssql

Conversation

@ujfalusis

Copy link
Copy Markdown
Contributor

Description

Pull Request #5790 broke the build on the main branch. This change disables the comment registration with the Fabric engine.

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

@ujfalusis

Copy link
Copy Markdown
Contributor Author

@StuffbyYuki
Could you take a look at this?

@StuffbyYuki StuffbyYuki self-requested a review June 26, 2026 14:10

@StuffbyYuki StuffbyYuki left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! No blocker other than the failed ci test, but do you think it's worth

  • adding a brief comment explaining why (like Athena)
  • adding a small test_fabric.py assertion

@ujfalusis

Copy link
Copy Markdown
Contributor Author

@StuffbyYuki

  • Comment added to the Fabric engine class where comments are disabled
  • Added one unit test for Fabric and one for MSSQL

Have a nice day,
@ujfalusis

@StuffbyYuki StuffbyYuki merged commit 2318ffc into SQLMesh:main Jun 29, 2026
62 of 63 checks passed
EhabEasee pushed a commit to EhabEasee/sqlmesh that referenced this pull request Jun 30, 2026
Signed-off-by: Ujfalusi Sándor <ujfalusi.sandor@gmail.com>
Signed-off-by: EhabEasee <ehab.elbadrawi@easee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants